Remove auth-nextjs-themed #4888
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
|
I'd prefer it be left in. When I'm reviewing a product to see if it's useful, I load up the template. This is the template I used to decide I should use toolpad |
|
I agree that this example is different to the others, and adds a lot of maintenance overhead due to its complexity, which is even worse if people use it as a starter. Other than that the only current issue it seems to have is that the |
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing to remove the example. it seems to be more of a template than an example. An example should be terse, to the point and demonstrate a single aspect of the product. It doesn't work when checked out and instructions are followed. It declares incompatible dependencies (react spring) and it redirects to codesandbox on start, it also includes secrets in .env. The reason why we want them simple is because they're easier to maintain.
To setup something specific for codesandbox, it may be better to use a task