[examples] Remove React Spring from themed example #4890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
bharatkashyap
approved these changes
Apr 25, 2025
|
Sounds good! Better solution imo than removing the example outright which seems to suggest that the maintenance overhead with our own version upgrades is so great that we can't take it on. |
It's ok, we can just discuss it! Thanks for approving, just gonna need to merge #4891 first for the build to pass, it seems. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #4888, the React Spring dependency is preventing the
auth-nextjs-themedexample from properly installing as it's not compatible with React 19 and not being actively maintained enough.This replacement with the MUI
Collapsecomponent seems to be similar enough and makes it so we don't need React Spring.Before:
Screen.Recording.2025-04-25.at.18.19.29.mov
After:
Screen.Recording.2025-04-25.at.18.18.57.mov