chore: Replaced aTimeout with waitUntil to address flaky tests#1284
chore: Replaced aTimeout with waitUntil to address flaky tests#1284spuppo-mux merged 9 commits intomuxinc:mainfrom
aTimeout with waitUntil to address flaky tests#1284Conversation
|
@spuppo-mux is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
==========================================
- Coverage 78.55% 73.58% -4.97%
==========================================
Files 59 56 -3
Lines 11080 13873 +2793
Branches 0 783 +783
==========================================
+ Hits 8704 10209 +1505
- Misses 2376 3631 +1255
- Partials 0 33 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aTimeout with waitUntilaTimeout with waitUntil to address flaky tests
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 33a98bb. Configure here.

Closes https://github.com/muxinc/devextravaganza/issues/216
Changes to try to reduce test flakiness for Webkit runs.
For example on: https://github.com/muxinc/media-chrome/actions/runs/23017090932/job/66843131347
Also added a step to try to improve run time on job reruns, since they sometimes take more than 20 mins
Before changes (
Run npx playwright install-depsstep) :After changes:
Note: changes inspired by these two posts microsoft/playwright - [Question] Speed up installing browsers in GitHub Actions and related actions/runner - man-db trigger severely stalls package installation on ubuntu-24.04 runners #4030
Note
Low Risk
Low risk: changes are limited to CI/CD workflow steps and test timing/await logic; main risk is longer test timeouts potentially masking legitimate hangs.
Overview
Stabilizes Playwright-driven unit tests and speeds up GitHub Actions runs. CI and CD workflows now remove
man-dbbefore Playwright dependency installs to reduceaptdelays on Ubuntu runners.Updates flaky tests to rely on
waitUntil(with longer per-suite timeouts and explicit failure messages) instead of fixedaTimeoutsleeps, and addspreload="auto"to the test video fixture to make state assertions more deterministic (notably on WebKit).Reviewed by Cursor Bugbot for commit 2aedbfd. Bugbot is set up for automated code reviews on this repo. Configure here.