Skip to content

chore: Replaced aTimeout with waitUntil to address flaky tests#1284

Merged
spuppo-mux merged 9 commits intomuxinc:mainfrom
spuppo-mux:chore/fix-flaky-tests
Apr 9, 2026
Merged

chore: Replaced aTimeout with waitUntil to address flaky tests#1284
spuppo-mux merged 9 commits intomuxinc:mainfrom
spuppo-mux:chore/fix-flaky-tests

Conversation

@spuppo-mux
Copy link
Copy Markdown
Contributor

@spuppo-mux spuppo-mux commented Apr 7, 2026

Closes https://github.com/muxinc/devextravaganza/issues/216

Changes to try to reduce test flakiness for Webkit runs.
For example on: https://github.com/muxinc/media-chrome/actions/runs/23017090932/job/66843131347

Also added a step to try to improve run time on job reruns, since they sometimes take more than 20 mins

Before changes (Run npx playwright install-deps step) :

image

After changes:

image

Note: changes inspired by these two posts microsoft/playwright - [Question] Speed up installing browsers in GitHub Actions and related actions/runner - man-db trigger severely stalls package installation on ubuntu-24.04 runners #4030


Note

Low Risk
Low risk: changes are limited to CI/CD workflow steps and test timing/await logic; main risk is longer test timeouts potentially masking legitimate hangs.

Overview
Stabilizes Playwright-driven unit tests and speeds up GitHub Actions runs. CI and CD workflows now remove man-db before Playwright dependency installs to reduce apt delays on Ubuntu runners.

Updates flaky tests to rely on waitUntil (with longer per-suite timeouts and explicit failure messages) instead of fixed aTimeout sleeps, and adds preload="auto" to the test video fixture to make state assertions more deterministic (notably on WebKit).

Reviewed by Cursor Bugbot for commit 2aedbfd. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

@spuppo-mux is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Apr 7, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.58%. Comparing base (3ea80df) to head (2aedbfd).
⚠️ Report is 297 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
- Coverage   78.55%   73.58%   -4.97%     
==========================================
  Files          59       56       -3     
  Lines       11080    13873    +2793     
  Branches        0      783     +783     
==========================================
+ Hits         8704    10209    +1505     
- Misses       2376     3631    +1255     
- Partials        0       33      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spuppo-mux spuppo-mux marked this pull request as ready for review April 7, 2026 15:47
@spuppo-mux spuppo-mux requested review from a team and heff as code owners April 7, 2026 15:47
@spuppo-mux spuppo-mux changed the title chore: Replaced aTimeout with waitUntil chore: Replaced aTimeout with waitUntil to address flaky tests Apr 7, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 33a98bb. Configure here.

@spuppo-mux spuppo-mux merged commit 9f502c3 into muxinc:main Apr 9, 2026
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants