Skip to content

Allow adding additional data to pre-selected dataset#206

Merged
AndreiSavici merged 2 commits intonextfrom
dataset_updates
Jan 14, 2026
Merged

Allow adding additional data to pre-selected dataset#206
AndreiSavici merged 2 commits intonextfrom
dataset_updates

Conversation

@KyleQianliMa
Copy link
Member

@KyleQianliMa KyleQianliMa commented Jan 14, 2026

Short description of the changes:

Previously, once user pre-selects a dataset, control + click on additional raw data would reset the highlighted data. This pr preserves previous selection.

Additionally, it automatically fixed an issue where "advanced" option tab would wipe the selected raw data list when the dataset is in "custom" mode.

Video below shows the correct behavior.

Screencast.from.2026-01-14.13-37-23.webm

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.75%. Comparing base (de32ef1) to head (c457374).
⚠️ Report is 1 commits behind head on next.

Files with missing lines Patch % Lines
src/shiver/views/reduction_parameters.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #206      +/-   ##
==========================================
- Coverage   88.78%   88.75%   -0.04%     
==========================================
  Files          39       39              
  Lines        6190     6196       +6     
==========================================
+ Hits         5496     5499       +3     
- Misses        694      697       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndreiSavici AndreiSavici enabled auto-merge (squash) January 14, 2026 20:53
Copy link
Member

@AndreiSavici AndreiSavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@AndreiSavici AndreiSavici merged commit 1b4c5f8 into next Jan 14, 2026
6 of 8 checks passed
@AndreiSavici AndreiSavici deleted the dataset_updates branch January 14, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants