Skip to content

Allow adding additional data to pre-selected dataset #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreiSavici merged 2 commits into from
Jan 14, 2026
Merged

Allow adding additional data to pre-selected dataset #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4075bd
block dataset update signal
KyleQianliMa Jan 14, 2026
c457374
fix advanced option apply clearing selection
KyleQianliMa Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/shiver/views/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,11 @@ def update_raw_data_widget_selection(
def set_dataset_to_custom(self):
"""Set the dataset in the oncat widget to "custom"."""
if not self.inhibit_update:
self.oncat_widget.set_dataset_to_custom()
self.oncat_widget.dataset.blockSignals(True)
try:
self.oncat_widget.set_dataset_to_custom()
finally:
self.oncat_widget.dataset.blockSignals(False)

def _update_title(self, mde_name: str):
"""Update the title of the widget to include the MDE name"""
Expand Down
5 changes: 4 additions & 1 deletion src/shiver/views/reduction_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,14 @@ def set_adv_btn(self):
"""Open the dialog to set advanced options"""
dialog = AdvancedDialog(self)
self.active_dialog = dialog
goniometer = ""
# populate the dialog
if self.dict_advanced:
goniometer = self.dict_advanced["Goniometer"]
dialog.populate_advanced_options_from_dict(self.dict_advanced)
dialog.exec_()
self.advanced_apply_callback(self.dict_advanced)
if self.dict_advanced["Goniometer"] != goniometer:
self.advanced_apply_callback(self.dict_advanced)
self.active_dialog = None

def set_pol_btn(self):
Expand Down