-
Notifications
You must be signed in to change notification settings - Fork 95
fix(NcRichText): Allow markdown parenthesis in URL_PATTERN #6224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable8
Are you sure you want to change the base?
fix(NcRichText): Allow markdown parenthesis in URL_PATTERN #6224
Conversation
I'm not sure which milestones and branches are used in this repo, so feel free to backport however you see fit. |
Signed-off-by: provokateurin <[email protected]>
b3858e2
to
013ae78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs extensive tests added to not break cases like:
Please check the website (https://nextcloud.com/)
Please check the website https://nextcloud.com/wikipedia_(has-braces)
And the likes. It was a long fight with usability of most users. So we really prefer broken previous over broken UX of normal users posting behaviour
The problem here is also that something like this would wrongly be parsed: |
TBH I don't understand why it would be a problem, since URLs must be encoded and therefore can't contain plain braces. |
Depends on the moment of parsing, no? Because if you copy paste an URL from the browser address bar it will contain the |
Because day-to-day usage shows that they are not pasted encoded, users don't encode and we receive multiple reports in the week after a Talk release when someone changes this 🙈 The problem is even a step further, there are URLs where the brackets are expected (most famous is wikipedia)
|
The URL_PATTERN_AUTOLINK regex already allowed parenthesis from markdown, so the links were clickable, but there was no preview shown due to this regex not allowing them.
☑️ Resolves
🏁 Checklist
next
requested with a Vue 3 upgrade