Decouple SCM classes in Nextflow independent module#6740
Draft
Decouple SCM classes in Nextflow independent module#6740
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Member
|
I have the feeling that #6719 is a better approach. What's the advantage of this PR ? |
Contributor
Author
|
In this PR, classes are not depending on nf-commons. only nf-utils and nf-scm are required to move to libseqera. In the other, you require to get nf-commons, nf-secrets, nf-config and nf-scm. |
Member
|
I understand but in my view this refactor is going too far. I think should stay in nextflow repository, other apps still benefits avoiding to import all nextflow runtime full deps tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Nextflow asset management to decouple the SCM functionality form the rest of the Nextflow code.
Two new packages are created
nf-scm: Contains the SCM classes decouple from the rest of nextflow classesnf-utils: Contains util clases required by SCM and the rest of nextflowalternative for #6719