Allow boolean params to implicitly default to false#6764
Open
bentsherman wants to merge 1 commit intomasterfrom
Open
Allow boolean params to implicitly default to false#6764bentsherman wants to merge 1 commit intomasterfrom
bentsherman wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
What value they default now? null? |
Member
Author
|
Right now they don't default to anything, so you have to specify a default value yourself (e.g. This is reasonable for other types, but for boolean it seems like it should just default to false if you don't declare a default value. |
Member
|
Think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of boolean params in the
paramsblock so that they implicitly default tofalse. This way the user doesn't have to specify... = falsefor every boolean param, which seems to be the desired behavior 99.9% of the time.@ewels let me know if you think this makes sense