Fix type detection of CLI params in v2 config parser#6765
Open
bentsherman wants to merge 1 commit intomasterfrom
Open
Fix type detection of CLI params in v2 config parser#6765bentsherman wants to merge 1 commit intomasterfrom
bentsherman wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spun off from #6760 (comment)
This PR applies the CLI type detection from the
paramsblock to also work with config params. When a CLI param overrides a config param, the CLI param is converted to the appropriate type based on the default param value in the config.Type annotations can't be specified in the config like they can in the script, but we can almost always infer the intended type from the default value:
Without this, users would have to assume that all config params are strings and convert them appropriately. But with this PR I think we can recover all of the functionality of the legacy type detection that users rely on, and even make it a bit more robust.
@ewels let me know if this change makes sense