Fix JGit resources not being closed in CLI commands#6795
Draft
pditommaso wants to merge 1 commit intomasterfrom
Draft
Fix JGit resources not being closed in CLI commands#6795pditommaso wants to merge 1 commit intomasterfrom
pditommaso wants to merge 1 commit intomasterfrom
Conversation
AssetManager now implements Closeable and CLI commands wrap manager usage in try-finally blocks to ensure JGit resources are properly released. This prevents ~90 second shutdown delays caused by JGit shutdown hooks cleaning up unclosed Repository objects. Signed-off-by: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssetManagerimplementCloseableinterfaceAssetManagerusage in CLI commands with try-finally blocks to ensureclose()is calledRepositoryobjectsProblem
JGit registers shutdown hooks when
Repositoryobjects are created. When these are not closed viaclose(), the cleanup runs during JVM shutdown, causing significant delays:Note the ~94 second gap between
Runtime.exit(0)and JGit cleanup.Changes
AssetManager.groovy: Addedimplements CloseableCmdRun.groovy: Wrapped manager usage in try-finallyCmdPull.groovy: Wrapped manager usages in try-finallyCmdView.groovy: Wrapped manager usage in try-finallyCmdClone.groovy: Wrapped manager usage in try-finallyCmdInfo.groovy: Wrapped manager usage in try-finallyCmdConfig.groovy: Wrapped manager usage in try-finallyCmdDrop.groovy: Wrapped manager usage in try-finallyTest plan
make testto verify existing tests pass