feat: add dataset metadata fields and improve community filtering#1754
Merged
ivan-aksamentov merged 4 commits intomasterfrom Mar 5, 2026
Merged
feat: add dataset metadata fields and improve community filtering#1754ivan-aksamentov merged 4 commits intomasterfrom
ivan-aksamentov merged 4 commits intomasterfrom
Conversation
…aset Dataset pathogen.json files use top-level metadata flags (enabled, deprecated, experimental, official, maintenance) that were silently absorbed by the serde flatten catch-all. Add explicit fields so they are recognized by schema validation and accessible in Rust code. - Add `DatasetMaintenance` struct with typed fields for contact URLs - Add `enabled`, `deprecated`, `experimental`, `official`, `maintenance` to `VirusProperties` - Add `enabled`, `maintenance` to `Dataset` (present in index.json)
…etection Remove the `official` field from VirusProperties and Dataset structs. Replace `Dataset::official()` with `Dataset::is_community()` which checks if path starts with `community/`. This properly handles the three dataset collections (nextstrain, enpen, community) where only community datasets should be filtered by `--no-community`.
The enabled field was never used - deprecated serves the same purpose. Remove from VirusProperties, Dataset structs and regenerate schemas.
ivan-aksamentov
added a commit
that referenced
this pull request
Mar 5, 2026
…m VirusProperties These root-level fields are no longer read by Nextclade. Since #1754, both values are read from attributes.get("deprecated") and attributes.get("experimental") in Dataset.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit schema fields for dataset metadata (
deprecated,experimental,maintenance) that were previously absorbed by serde's flatten catch-all, enabling proper schema validation during data rebuild. Replace theofficialfield with path-based community detection so--no-communitynow correctly filters only datasets in thecommunity/collection rather than all non-nextstrain datasets. Remove the unusedenabledfield which was redundant withdeprecated.deprecated,experimental,maintenancefields to VirusProperties structDatasetMaintenancestruct for contact URLs (website, docs, issues, authors)Dataset::official()withDataset::is_community()checkingcommunity/prefix--no-communityCLI filter to use new path-based detectionenabledandofficialfields from schemasSibling PRs in data: nextstrain/nextclade_data#413, nextstrain/nextclade_data#414