Skip to content

Blazor: Reorganize files and prepend NationalInstruments namespace#2892

Open
m-akinc wants to merge 17 commits intomainfrom
users/makinc/namespace-blazor
Open

Blazor: Reorganize files and prepend NationalInstruments namespace#2892
m-akinc wants to merge 17 commits intomainfrom
users/makinc/namespace-blazor

Conversation

@m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Mar 9, 2026

Pull Request

🤨 Rationale

For consistency with other NI-authored binaries, we want the Blazor assemblies from this repo to be namespaced under NationalInstruments.

Also, we want to reorganize the Blazor projects to better match the structure of the "components" packages. Fixes #2865

👩‍💻 Implementation

  • changed namespaces and assembly names from FooBlazor to NationalInstruments.FooBlazor
  • moved components .razor and .razor.cs files into component-specific subdirectories
  • moved component-specific type files into said directories
  • renamed Components folder to Source
  • moved shared files from the root into a Source/Patterns directory

🧪 Testing

Build/tests pass

@m-akinc m-akinc changed the title Prepend NationalInstruments to Blazor namespaces Blazor: Reorganize files and prepend NationalInstruments to Blazor namespaces Mar 9, 2026
@m-akinc m-akinc changed the title Blazor: Reorganize files and prepend NationalInstruments to Blazor namespaces Blazor: Reorganize files and prepend NationalInstruments namespace Mar 9, 2026
Copy link
Member

@rajsite rajsite Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For folders that are nested let's align on the naming conventions in other libraries by not repeating the full parent folder in the name, i.e TableColumn\TableColumnAnchor\ -> TableColumn\Anchor\

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-opening as the following are not aligned with the other library layouts:

LabelProviderCore -> LabelProvider\Core
LabelProviderTable -> LabelProvider\Table
'Mapping\NimbleMappingBase.cs' -> Mapping\Base\NimbleMappingBase.cs
RichTextViewer -> RichText\Viewer
TableColumn\NimbleTableColumn.cs -> TableColumn\Base\NimbleTableColumn.cs
TableColumn\NimbleTableColumnEnumBase.cs -> TableColumn\EnumBase\NimbleTableColumnEnumBase.cs

@m-akinc m-akinc requested a review from rajsite March 19, 2026 17:46
@m-akinc m-akinc marked this pull request as ready for review March 19, 2026 17:47
@m-akinc m-akinc requested a review from msmithNI as a code owner March 19, 2026 17:47
@m-akinc m-akinc enabled auto-merge (squash) March 19, 2026 17:48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-opening as the following are not aligned with the other library layouts:

LabelProviderCore -> LabelProvider\Core
LabelProviderTable -> LabelProvider\Table
'Mapping\NimbleMappingBase.cs' -> Mapping\Base\NimbleMappingBase.cs
RichTextViewer -> RichText\Viewer
TableColumn\NimbleTableColumn.cs -> TableColumn\Base\NimbleTableColumn.cs
TableColumn\NimbleTableColumnEnumBase.cs -> TableColumn\EnumBase\NimbleTableColumnEnumBase.cs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spright as well:

Chat\MessageInbound -> Chat\Message\Inboud
Chat\MessageOutbound -> Chat\Message\Outboud
Chat\MessageSystem -> Chat\Message\System

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blazor source file layout improvements

3 participants