Blazor: Reorganize files and prepend NationalInstruments namespace#2892
Blazor: Reorganize files and prepend NationalInstruments namespace#2892
Conversation
There was a problem hiding this comment.
For folders that are nested let's align on the naming conventions in other libraries by not repeating the full parent folder in the name, i.e TableColumn\TableColumnAnchor\ -> TableColumn\Anchor\
There was a problem hiding this comment.
Re-opening as the following are not aligned with the other library layouts:
LabelProviderCore -> LabelProvider\Core
LabelProviderTable -> LabelProvider\Table
'Mapping\NimbleMappingBase.cs' -> Mapping\Base\NimbleMappingBase.cs
RichTextViewer -> RichText\Viewer
TableColumn\NimbleTableColumn.cs -> TableColumn\Base\NimbleTableColumn.cs
TableColumn\NimbleTableColumnEnumBase.cs -> TableColumn\EnumBase\NimbleTableColumnEnumBase.cs
There was a problem hiding this comment.
Re-opening as the following are not aligned with the other library layouts:
LabelProviderCore -> LabelProvider\Core
LabelProviderTable -> LabelProvider\Table
'Mapping\NimbleMappingBase.cs' -> Mapping\Base\NimbleMappingBase.cs
RichTextViewer -> RichText\Viewer
TableColumn\NimbleTableColumn.cs -> TableColumn\Base\NimbleTableColumn.cs
TableColumn\NimbleTableColumnEnumBase.cs -> TableColumn\EnumBase\NimbleTableColumnEnumBase.cs
There was a problem hiding this comment.
Spright as well:
Chat\MessageInbound -> Chat\Message\Inboud
Chat\MessageOutbound -> Chat\Message\Outboud
Chat\MessageSystem -> Chat\Message\System
Pull Request
🤨 Rationale
For consistency with other NI-authored binaries, we want the Blazor assemblies from this repo to be namespaced under
NationalInstruments.Also, we want to reorganize the Blazor projects to better match the structure of the "components" packages. Fixes #2865
👩💻 Implementation
FooBlazortoNationalInstruments.FooBlazor.razorand.razor.csfiles into component-specific subdirectoriesComponentsfolder toSourceSource/Patternsdirectory🧪 Testing
Build/tests pass