-
Notifications
You must be signed in to change notification settings - Fork 11
Blazor: Reorganize files and prepend NationalInstruments namespace #2892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c767645
f294e9c
90d6be2
a351b4e
356d7e4
d744012
25e3273
291c761
0437b4d
fc2228e
d21bd5d
cd0aa20
edfc9a2
e293d75
b51bdf9
d7cbd60
74e963a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For folders that are nested let's align on the naming conventions in other libraries by not repeating the full parent folder in the name, i.e
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Re-opening as the following are not aligned with the other library layouts:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Spright as well:
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "major", | ||
| "comment": "Prepend NationalInstruments to Blazor namespaces", | ||
| "packageName": "@ni/nimble-blazor", | ||
| "email": "7282195+m-akinc@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "major", | ||
| "comment": "Prepend NationalInstruments to Blazor namespaces", | ||
| "packageName": "@ni/ok-blazor", | ||
| "email": "7282195+m-akinc@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "major", | ||
| "comment": "Prepend NationalInstruments to Blazor namespaces", | ||
| "packageName": "@ni/spright-blazor", | ||
| "email": "7282195+m-akinc@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| @using Microsoft.AspNetCore.Components.Web | ||
| @using NimbleBlazor | ||
| @using NationalInstruments.NimbleBlazor |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| [assembly: InternalsVisibleTo("NimbleBlazor.Tests")] | ||
| [assembly: InternalsVisibleTo("NationalInstruments.NimbleBlazor.Tests")] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| namespace NimbleBlazor; | ||
| namespace NationalInstruments.NimbleBlazor; | ||
|
|
||
| public enum BannerSeverity | ||
| { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.