ENH: Generalize iterators to accept bvals or uptake as kwargs
#238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
enh/generalize-iterators
branch
from
08c29dc to
80de628
Compare
|
Partially addresses #230. It remains the question about the |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
- Coverage 78.65% 78.38% -0.28%
==========================================
Files 24 24
Lines 1443 1457 +14
Branches 166 168 +2
==========================================
+ Hits 1135 1142 +7
- Misses 237 244 +7
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Sep 29, 2025
Generalize iterators to accept `bvals` or `uptake` as keyword arguments. The previous implementation of the linear, random and centralsym iterators was only accepting `bvals`. This patch set allows these iterators to work with PET data through the `uptake` argument. Document the functions by explicitly assigning the docstring to the `__doc__` property of each function so that the `SIZE_KEYS_DOC` can be reused and to allow the examples be run by the doctring tests.
jhlegarreta
force-pushed
the
enh/generalize-iterators
branch
from
80de628 to
87ca171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize iterators to accept
bvalsoruptakeas keyword arguments. The previous implementation of the linear, random and centralsym iterators was only acceptingbvals. This patch set allows these iterators to work with PET data through theuptakeargument.Document the functions by explicitly assigning the docstring to the
__doc__property of each function so that theSIZE_KEYS_DOCcan be reused and to allow the examples be run by the doctring tests.