Skip to content

Conversation

@ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Nov 7, 2025

The test was useless for testing --zero-fill-buffers flag, which is what it was supposed to test.

  1. Buffer.allocUnsafeSlow(20) is zero-filled regardless of the flag because it's from heap (<=64), not an alloc

  2. 50 first calls to Buffer.allocUnsafe(20) were zero-filled regardless of the flag because they all come from the pool which was in the snapshot, and no real runtime alloc was made.

This PR fixes the test, so it now fails without the flag (as expected).

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2025
@RafaelGSS RafaelGSS added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2025
@nodejs-github-bot
Copy link
Collaborator

@ChALkeR ChALkeR force-pushed the chalker/fix-test/0 branch from c222159 to c69267a Compare November 7, 2025 18:58
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2025
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (dbe45b7) to head (c69267a).
⚠️ Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60623      +/-   ##
==========================================
+ Coverage   88.54%   88.55%   +0.01%     
==========================================
  Files         704      704              
  Lines      207843   208097     +254     
  Branches    40044    40079      +35     
==========================================
+ Hits       184028   184283     +255     
+ Misses      15858    15833      -25     
- Partials     7957     7981      +24     

see 62 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants