Skip to content

test: fix test-buffer-zero-fill-cli to be effective #60623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: fix test-buffer-zero-fill-cli to be effective #60623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion test/parallel/test-buffer-zero-fill-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ function isZeroFilled(buf) {
return true;
}

// We have to consume the data from the pool as otherwise
// we would be testing what's in snapshot, which is zero-filled
// regardless of the flag presence, and we want to test the flag
for (let i = 0; i < 8; i++) {
assert(isZeroFilled(Buffer.allocUnsafe(1024)));
}

// This can be somewhat unreliable because the
// allocated memory might just already happen to
// contain all zeroes. The test is run multiple
Expand All @@ -22,7 +29,8 @@ for (let i = 0; i < 50; i++) {
const bufs = [
Buffer.alloc(20),
Buffer.allocUnsafe(20),
Buffer.allocUnsafeSlow(20),
Buffer.allocUnsafeSlow(20), // Heap
Buffer.allocUnsafeSlow(128), // Alloc
Buffer(20),
];
for (const buf of bufs) {
Expand Down
Loading