[nrf toup] [nrfconnect] Remove dependency to DK in Matter configuration #644
Conversation
| config CHIP_WIFI | ||
| bool "Enable nrfconnect Wi-Fi support" | ||
| default y if SHIELD_NRF7002EK || BOARD_NRF7002DK_NRF5340_CPUAPP || SHIELD_NRF7002EB || BOARD_NRF7002DK_NRF5340_CPUAPP_NRF7001 | ||
| select WIFI_NRF70 |
There was a problem hiding this comment.
Why have you removed selecting WI_FI symbols? Isn't better to have single Kconfig that selects all what we need?
There was a problem hiding this comment.
Those symbols are not needed here anymore, I will try to leave WIFI_NRF70 here and set CHIP_WIFI in samples.
| config CHIP_QSPI_NOR | ||
| bool "Enable QSPI NOR feature set" | ||
| imply NORDIC_QSPI_NOR | ||
| default y if NORDIC_QSPI_NOR |
There was a problem hiding this comment.
I think that this symbol becomes pointless now. It was created to enable required nrf/zephyr symbols from Matter. If you want to set it in a reversed order, just use NORDIC_QSPI_NOR in .cpp code and remove this symbol at all.
| imply SPI | ||
| imply SPI_NOR | ||
| imply MULTITHREADING | ||
| default y if SPI_NOR |
There was a problem hiding this comment.
Ditto, I don't think we need this symbol if it's going to be set by nrf symbol.
There was a problem hiding this comment.
Btw who is going to set SPI_NOR now? I don't see it in Matter samples
There was a problem hiding this comment.
Driver itself according to DTS
There was a problem hiding this comment.
Cool, it must be something "new", because few years back it was not working like this.
|
|
||
| config CHIP_DFU_OVER_BT_SMP | ||
| bool "Enable DFU over Bluetooth LE SMP feature set" | ||
| imply CHIP_QSPI_NOR if BOARD_NRF5340DK_NRF5340_CPUAPP || BOARD_NRF52840DK_NRF52840 |
There was a problem hiding this comment.
The same question, who is going to take care of enabling SPI_NOR/QSPI_NOR? Our documentation says it's enough to enable this config to support DFU, but now it is not going to be true.
There was a problem hiding this comment.
Now it is set by driver.
In Matter configuration there must not be anything related to DK. All DK-related Kconfigs must be defined in the application. Signed-off-by: Arkadiusz Balys <[email protected]>
ArekBalysNordic
force-pushed
the
remove_dk_dependency
branch
from
21fdcdc to
e64e2eb
Compare
In Matter configuration there must not be anything related to DK. All DK-related Kconfigs must be defined in the application.
Testing
NRF
manifest-pr-skip