Conversation
| -- various cases when encoding a dependent sum of type `(R p)`. | ||
| data SegmentResult check parse a = | ||
| PathEnd (Encoder check parse a (Map Text (Maybe Text))) | ||
| data SegmentResult check parse a b = |
There was a problem hiding this comment.
Breaking change - migration while keeping old meaning is to use (Map Text (Maybe Text)) for b, but sometimes this can be generalized, as with indexOnlyRouteSegment.
Do we want to do a proper warn-first-break-later migration cycle at the cost of polluting the namespace with a SegmentResult' or so for a few releases?
|
Ended up also locally defining a variant of I wonder if this should be more of a generalise-query-type thing. In theory we could do the same for path, so instead of At least allowing |
dc7a7a9 to
64db94f
Compare
Ran into a non-urls usecase where I wanted to use
([Text], ByteString)instead of([Text], Map Text (Maybe Text))and realized the groundwork for #989 allowed me to use([Text], q)as long as I relaxed the type signatures so I pulled that bit into this separate, more conservative PR.The tutorial describes the
PageNameversion ofpathComponentEncoder. Should that be updated with this PR or do we keep it simple?I have:
developbranchhlint .(lint found code you did not write can be left alone)$(nix-build -A selftest --no-out-link)nix-build release.nix -A build.x86_64-linux --no-out-link(orx86_64-darwinon macOS)