Allow sharing query parameters at route branches#989
Open
alexfmpe wants to merge 3 commits intoobsidiansystems:developfrom
Open
Allow sharing query parameters at route branches#989alexfmpe wants to merge 3 commits intoobsidiansystems:developfrom
alexfmpe wants to merge 3 commits intoobsidiansystems:developfrom
Conversation
alexfmpe
commented
Sep 26, 2022
| , queryParametersTextEncoder | ||
| , integralEncoder | ||
| , pathSegmentEncoder | ||
| , pathOnlyEncoderIgnoringQuery |
Contributor
Author
There was a problem hiding this comment.
Probably should be exported - I end up inlining this in every project
f86920b to
e674ce5
Compare
alexfmpe
commented
Sep 26, 2022
c883dae to
2a21612
Compare
Contributor
Author
|
Rebased on top of #1079 |
2a21612 to
7fb80c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: Rebased on top of #1079
Allows turning
into
and
into
Motivation
fooIgnoringQueryto be added all over the leaf routesI have:
developbranchhlint .(lint found code you did not write can be left alone)$(nix-build -A selftest --no-out-link)nix-build release.nix -A build.x86_64-linux --no-out-link(orx86_64-darwinon macOS)