Skip to content

Fix incorrect binding of negative ints #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fix incorrect binding of negative ints #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9708ba2
Exhibit incorrect binding of negative int (#31)
ghuysmans Jul 10, 2023
81e2a49
Fix Bind.int: use MYSQL_TYPE_LONG (fix #31)
ghuysmans Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/blocking/blocking_example.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ let stream res =
let main () =
let mariadb = connect () |> or_die "connect" in
let query = env "OCAML_MARIADB_QUERY"
"SELECT * FROM mysql.user WHERE User LIKE ?" in
"SELECT * FROM mysql.user WHERE User LIKE ? AND ? < 0" in
let stmt = M.prepare mariadb query |> or_die "prepare" in
let res = M.Stmt.execute stmt [| `String "r%" |] |> or_die "exec" in
let res = M.Stmt.execute stmt [| `String "r%"; `Int (-1) |] |> or_die "exec" in
assert (M.Res.affected_rows res = M.Res.num_rows res);
printf "#rows: %d\n%!" (M.Res.num_rows res);
let s = stream res in
Expand Down
2 changes: 1 addition & 1 deletion lib/bind.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ let int ?(unsigned = false) b param ~at =
bind b
~buffer:(coerce (ptr int) (ptr void) p)
~size:(sizeof int)
~mysql_type:T.Type.long_long
~mysql_type:T.Type.long
~unsigned:(if unsigned then yes else no)
~at

Expand Down