Fix incorrect binding of negative ints #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the manual[1], C ints are tagged with MYSQL_TYPE_LONG. Using MYSQL_TYPE_LONGLONG, the buffer got padded with zeros. While it worked for positive ints, we got the unsigned interpretation of negative ints, e.g. -1 became 4294967295 (0xFFFFFFFF00000000, LE). [1]: https://dev.mysql.com/doc/c-api/5.7/en/c-api-prepared-statement-type-codes.html
|
I suggest we merge this, considering the past discussion in #54 and the fact that it fixes #57. To elaborate, the latter issue shows that the OCaml and C integers must match when we pass integers to MariaDB, since it does not honour the passed size field. The size field is probably meant for varchar and non-scalar fields. And |
|
Thanks, this is an important fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.