Skip to content

Conversation

@Tyoneb
Copy link

@Tyoneb Tyoneb commented Nov 3, 2025

Fixes #4817

Copy link
Collaborator

@azmy60 azmy60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested a minor change, but overall this seems good!

sourceMap: true,
plugins: [require('postcss-prettify')]
plugins: [require('postcss-prettify')],
use: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we not silent the deprecations? I'm not sure if it's a good idea, though we should fix them at some point, instead of hiding them like this.

@azmy60
Copy link
Collaborator

azmy60 commented Jan 12, 2026

@Tyoneb Unfortunately, I just noticed this is a duplicate of #4809. But thanks for the PR! I'm closing this now.

@azmy60 azmy60 closed this Jan 12, 2026
@Tyoneb
Copy link
Author

Tyoneb commented Jan 12, 2026

@Tyoneb Unfortunately, I just noticed this is a duplicate of #4809. But thanks for the PR! I'm closing this now.

That's not unfortunate at all, I'm actually really glad to see some activity here, and if you're willing to take the even bigger PR, that's even better!

Do you have news from Oli? Is he alright?

This repo is great but it lacks involvement from maintainers. It'd be really nice if you could review some of the open PRs, merge the good ones and release a new version! I have another pending PR that must be integrated to fix a very annoying issue...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabulator does not build with NodeJS > 18

2 participants