Skip to content

Replace node-sass by sass (Dart Sass) to support NodeJS >= 20 #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tyoneb wants to merge 1 commit into from
Closed

Replace node-sass by sass (Dart Sass) to support NodeJS >= 20 #4818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ npm-debug.log
/playwright-report/
/blob-report/
/playwright/.cache/

# VS Code
.vscode/
36 changes: 24 additions & 12 deletions build/Bundler.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,25 +59,25 @@ export default class Bundler{
console.log("Building Dev Package Bundles: ", env);
switch(env){
case "css":
this.bundleCSS(false);
break;
this.bundleCSS(false);
break;

case "esm":
this.bundleESM(false);
break;
this.bundleESM(false);
break;

case "umd":
this.bundleUMD(false);
break;
this.bundleUMD(false);
break;

case "wrappers":
this.buildWrappers();
break;
this.buildWrappers();
break;

default:
this.bundleCSS(false);
this.bundleESM(false);
break;
this.bundleCSS(false);
this.bundleESM(false);
break;
}
}

Expand Down Expand Up @@ -132,7 +132,19 @@ export default class Bundler{
extract: true,
minimize: minify,
sourceMap: true,
plugins: [require('postcss-prettify')]
plugins: [require('postcss-prettify')],
use: {
Copy link
Collaborator

@azmy60 azmy60 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we not silent the deprecations? I'm not sure if it's a good idea, though we should fix them at some point, instead of hiding them like this.

sass: {
silenceDeprecations: [
"import",
"color-functions",
"global-builtin",
"legacy-js-api",
"slash-div",
"function-units",
]
}
}
}),
],
onwarn:this._suppressUnnecessaryWarnings.bind(this),
Expand Down
Loading