pprof: add pprof.profile.comment #2861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Lehner <[email protected]>
florianl
force-pushed
the
pprof-comments
branch
from
1305da2 to
d4b2331
Compare
jhalliday
approved these changes
Oct 3, 2025
aalexand
reviewed
Oct 3, 2025
aalexand
reviewed
Oct 3, 2025
|
Thank you @florianl - left a couple of comments. |
aalexand
approved these changes
Oct 6, 2025
christos68k
approved these changes
Oct 20, 2025
trisch-me
approved these changes
Oct 20, 2025
github-project-automation
bot
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
lmolkova
approved these changes
Oct 20, 2025
lmolkova
reviewed
Oct 20, 2025
jsuereth
approved these changes
Oct 22, 2025
jsuereth
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
felixge
approved these changes
Oct 22, 2025
github-project-automation
bot
moved this from Ready to be Merged
to Needs More Approval
in Semantic Conventions Triage
florianl
added a commit
to florianl/opentelemetry-proto
that referenced
this pull request
Oct 22, 2025
Follow up as open-telemetry/semantic-conventions#2861 go merged. Signed-off-by: Florian Lehner <[email protected]>
florianl
added a commit
to florianl/opentelemetry-proto
that referenced
this pull request
Oct 22, 2025
Follow up as open-telemetry/semantic-conventions#2861 go merged. Signed-off-by: Florian Lehner <[email protected]>
lmolkova
added a commit
to open-telemetry/opentelemetry-proto
that referenced
this pull request
Oct 29, 2025
Follow up as open-telemetry/semantic-conventions#2861 go merged. Signed-off-by: Florian Lehner <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Profiling SIG intends to convert a field in the OTel Profiles signal into an attribute.
Friendly ping: @open-telemetry/profiling-approvers
Merge requirement checklist
[chore]