Skip to content

Migrate action order data from V1 -> V2 #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calumbell merged 5 commits into from
Apr 14, 2025
Merged

Migrate action order data from V1 -> V2 #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed1d1d5
added 'order' field to CreatureAction model
calumbell Apr 11, 2025
5442f20
added 'order' data to v2 CreatureActions (where it exists in v1)
calumbell Apr 12, 2025
f671ca8
add script used to migrate action from from v1->v2
calumbell Apr 12, 2025
2f51d7a
rerun converter script to catch edge-cases
calumbell Apr 12, 2025
cf6e2a5
updated tests to reflect changes in CreatureActions data
calumbell Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions api_v2/migrations/0030_creatureaction_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Generated by Django 5.1.2 on 2025-04-11 19:18

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('api_v2', '0029_merge_20250407_1910'),
]

operations = [
migrations.AddField(
model_name='creatureaction',
name='order',
field=models.SmallIntegerField(blank=True, help_text='The position in the list of features that a feature appears in its source statblock', null=True),
),
]
6 changes: 6 additions & 0 deletions api_v2/models/creature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,12 @@ class CreatureAction(HasName, HasDescription):
help_text='The type of action used.'
)

order = models.SmallIntegerField(
blank=True,
null=True,
help_text='The position in the list of features that a feature appears in its source statblock'
)

form_condition = models.CharField(
blank=True,
null=True,
Expand Down
9 changes: 9 additions & 0 deletions api_v2/tests/responses/TestObjects.test_creature_ancient_example.approved.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"key": "srd_ancient-red-dragon_bite",
"legendary_cost": 1,
"name": "Bite",
"order": 1,
"parent": "srd_ancient-red-dragon",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -70,6 +71,7 @@
"key": "srd_ancient-red-dragon_claw",
"legendary_cost": 1,
"name": "Claw",
"order": 2,
"parent": "srd_ancient-red-dragon",
"uses_param": null,
"uses_type": null
Expand All @@ -82,6 +84,7 @@
"key": "srd_ancient-red-dragon_detect",
"legendary_cost": 1,
"name": "Detect",
"order": 0,
"parent": "srd_ancient-red-dragon",
"uses_param": null,
"uses_type": null
Expand All @@ -94,6 +97,7 @@
"key": "srd_ancient-red-dragon_fire-breath",
"legendary_cost": 1,
"name": "Fire Breath",
"order": 5,
"parent": "srd_ancient-red-dragon",
"uses_param": null,
"uses_type": null
Expand All @@ -106,6 +110,7 @@
"key": "srd_ancient-red-dragon_frightful-presence",
"legendary_cost": 1,
"name": "Frightful Presence",
"order": 4,
"parent": "srd_ancient-red-dragon",
"uses_param": null,
"uses_type": null
Expand All @@ -118,6 +123,7 @@
"key": "srd_ancient-red-dragon_multiattack",
"legendary_cost": 1,
"name": "Multiattack",
"order": 0,
"parent": "srd_ancient-red-dragon",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -151,6 +157,7 @@
"key": "srd_ancient-red-dragon_tail",
"legendary_cost": 1,
"name": "Tail",
"order": 3,
"parent": "srd_ancient-red-dragon",
"uses_param": null,
"uses_type": null
Expand All @@ -163,6 +170,7 @@
"key": "srd_ancient-red-dragon_tail-attack",
"legendary_cost": 1,
"name": "Tail Attack",
"order": 1,
"parent": "srd_ancient-red-dragon",
"uses_param": null,
"uses_type": null
Expand All @@ -175,6 +183,7 @@
"key": "srd_ancient-red-dragon_wing-attack",
"legendary_cost": 2,
"name": "Wing Attack",
"order": 2,
"parent": "srd_ancient-red-dragon",
"uses_param": null,
"uses_type": null
Expand Down
2 changes: 2 additions & 0 deletions api_v2/tests/responses/TestObjects.test_creature_goblin_example.approved.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"key": "srd_goblin_scimitar",
"legendary_cost": 1,
"name": "Scimitar",
"order": 0,
"parent": "srd_goblin",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -70,6 +71,7 @@
"key": "srd_goblin_shortbow",
"legendary_cost": 1,
"name": "Shortbow",
"order": 1,
"parent": "srd_goblin",
"uses_param": null,
"uses_type": null
Expand Down
1 change: 1 addition & 0 deletions api_v2/tests/responses/TestObjects.test_creature_guard_example.approved.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
"key": "srd_guard_spear",
"legendary_cost": 1,
"name": "Spear",
"order": 0,
"parent": "srd_guard",
"uses_param": null,
"uses_type": null
Expand Down
9 changes: 9 additions & 0 deletions api_v2/tests/responses/TestObjects.test_creatureset_example.approved.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"key": "srd_camel_bite",
"legendary_cost": 1,
"name": "Bite",
"order": 0,
"parent": "srd_camel",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -364,6 +365,7 @@
"key": "srd_draft-horse_hooves",
"legendary_cost": 1,
"name": "Hooves",
"order": 0,
"parent": "srd_draft-horse",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -544,6 +546,7 @@
"key": "srd_elephant_gore",
"legendary_cost": 1,
"name": "Gore",
"order": 0,
"parent": "srd_elephant",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -577,6 +580,7 @@
"key": "srd_elephant_stomp",
"legendary_cost": 1,
"name": "Stomp",
"order": 1,
"parent": "srd_elephant",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -786,6 +790,7 @@
"key": "srd_mastiff_bite",
"legendary_cost": 1,
"name": "Bite",
"order": 0,
"parent": "srd_mastiff",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -995,6 +1000,7 @@
"key": "srd_mule_hooves",
"legendary_cost": 1,
"name": "Hooves",
"order": 0,
"parent": "srd_mule",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -1212,6 +1218,7 @@
"key": "srd_pony_hooves",
"legendary_cost": 1,
"name": "Hooves",
"order": 0,
"parent": "srd_pony",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -1402,6 +1409,7 @@
"key": "srd_riding-horse_hooves",
"legendary_cost": 1,
"name": "Hooves",
"order": 0,
"parent": "srd_riding-horse",
"uses_param": null,
"uses_type": null
Expand Down Expand Up @@ -1592,6 +1600,7 @@
"key": "srd_warhorse_hooves",
"legendary_cost": 1,
"name": "Hooves",
"order": 0,
"parent": "srd_warhorse",
"uses_param": null,
"uses_type": null
Expand Down
Loading