Migrate action order data from V1 -> V2 #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustjohnson
approved these changes
Apr 13, 2025
This was referenced Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in missing contextual information to the CreatureAction V2 model about the order in which to display actions in a creature's statblock. This data is encoded in the
orderproperty, which is an integer that represents the position in the actions/bonus actions/reactions/legendary actions list it appears.The bulk of the work undertaken was in writing a Python script for scraping the V1 data, extracting the ordering information, and adding it to the V2 data.
Related Issue
Closes #667
How was this tested
This fix was primarily tested by spot checking the data, either looking directly at the JSON data, or poking around the
/v2/creaturesendpoint on a Django test server.Tests were run via
pytest, and after test cases were updated to reflect the new shape of the API response all were passing