feat: allow running a poller on custom thread#98
Merged
tiagolobocastro merged 3 commits intorelease/2.9from Mar 6, 2026
Merged
feat: allow running a poller on custom thread#98tiagolobocastro merged 3 commits intorelease/2.9from
tiagolobocastro merged 3 commits intorelease/2.9from
Conversation
Member
tiagolobocastro
commented
Mar 2, 2026
This is a monotonic increasing id which begins at 1 and is used to identify threads. This id cannot overflow... a restart would be required. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Member
Author
|
@mergify backport develop |
Contributor
✅ Backports have been createdDetails
Cherry-pick of 9664a7f has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 9664a7f. 🟢 All jobs passed!But CI Insights is watching 👀 |
niladrih
approved these changes
Mar 2, 2026
This required refactoring the selection to add for 3 options: 1. current thread 2. new thread on specified core 3. explicitly specified thread This is useful as it allows us to run pollers on existing threads to avoid running down the thread message pool. Specifically for nvmx, rather than create a thread per replica, we'd now be able to share threads on each core per replica. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
26d8daf to
c34c74b
Compare
This should be done in a better way, but for now this will allow us to merge this. Probably we should commit a Cargo.lock here. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
c34c74b to
9664a7f
Compare
Abhinandan-Purkait
approved these changes
Mar 3, 2026
mergify bot
added a commit
that referenced
this pull request
Mar 10, 2026
feat: allow running a poller on custom thread (backport #98)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.