Skip to content

feat: allow running a poller on custom thread (backport #98)#99

Merged
mergify[bot] merged 2 commits intodevelopfrom
mergify/bp/develop/pr-98
Mar 10, 2026
Merged

feat: allow running a poller on custom thread (backport #98)#99
mergify[bot] merged 2 commits intodevelopfrom
mergify/bp/develop/pr-98

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 6, 2026

feat: allow running a poller on custom thread

This required refactoring the selection to add for 3 options:
1. current thread
2. new thread on specified core
3. explicitly specified thread

This is useful as it allows us to run pollers on existing threads
to avoid running down the thread message pool.
Specifically for nvmx, rather than create a thread per replica,
we'd now be able to share threads on each core per replica.

feat(thread): expose the thread id from Thread

This is a monotonic increasing id which begins at 1 and is used
to identify threads.
This id cannot overflow... a restart would be required.

This is an automatic backport of pull request #98 done by [Mergify](https://mergify.com).

This is a monotonic increasing id which begins at 1 and is used
to identify threads.
This id cannot overflow... a restart would be required.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
(cherry picked from commit e88f558)
This required refactoring the selection to add for 3 options:
1. current thread
2. new thread on specified core
3. explicitly specified thread

This is useful as it allows us to run pollers on existing threads
to avoid running down the thread message pool.
Specifically for nvmx, rather than create a thread per replica,
we'd now be able to share threads on each core per replica.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
(cherry picked from commit 1111cd8)
@mergify mergify bot requested a review from a team as a code owner March 6, 2026 15:03
@mergify mergify bot added the conflicts label Mar 6, 2026
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Mar 6, 2026

Cherry-pick of 9664a7f has failed:

On branch mergify/bp/develop/pr-98
Your branch is ahead of 'origin/develop' by 2 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 9664a7f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Cargo.toml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/pr-code-lint.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Copy Markdown

@openebs-ci openebs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved backport PR

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Mar 6, 2026

🧪 CI Insights

Here's what we observed from your CI run for e1be4fa.

🟢 All jobs passed!

But CI Insights is watching 👀

@tiagolobocastro tiagolobocastro force-pushed the mergify/bp/develop/pr-98 branch from 543806b to e1be4fa Compare March 10, 2026 00:00
@tiagolobocastro
Copy link
Copy Markdown
Member

@mergify queue

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Mar 10, 2026

Merge Queue Status

  • Entered queue2026-03-10 09:28 UTC · Rule: default
  • Checks started · in-place
  • 🚫 Left the queue2026-03-10 09:28 UTC · at e1be4fa81f8abf08ec6287c0efb6566d4b62c951

This pull request spent 5 seconds in the queue, including 1 second running CI.

Required conditions to merge
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • check-success = code-lint
  • check-success = commitlint
  • any of [🛡 GitHub branch protection]:
    • check-success = DCO
    • check-neutral = DCO
    • check-skipped = DCO
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-lint (ubuntu-latest)
    • check-neutral = rust-lint (ubuntu-latest)
    • check-skipped = rust-lint (ubuntu-latest)
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-lint (github-arm64-2c-8gb)
    • check-neutral = rust-lint (github-arm64-2c-8gb)
    • check-skipped = rust-lint (github-arm64-2c-8gb)
  • any of [🛡 GitHub branch protection]:
    • check-success = commitlint
    • check-neutral = commitlint
    • check-skipped = commitlint
  • any of [🛡 GitHub branch protection]:
    • check-success = nix-lint
    • check-neutral = nix-lint
    • check-skipped = nix-lint
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-dev (github-arm64-2c-8gb)
    • check-neutral = rust-dev (github-arm64-2c-8gb)
    • check-skipped = rust-dev (github-arm64-2c-8gb)
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-dev (ubuntu-latest)
    • check-neutral = rust-dev (ubuntu-latest)
    • check-skipped = rust-dev (ubuntu-latest)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

Reason

Pull request #99 has been dequeued, merge conditions unmatch:

  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • check-success = code-lint
  • check-success = commitlint
  • any of [🛡 GitHub branch protection]:
    • check-success = DCO
    • check-neutral = DCO
    • check-skipped = DCO
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-lint (ubuntu-latest)
    • check-neutral = rust-lint (ubuntu-latest)
    • check-skipped = rust-lint (ubuntu-latest)
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-lint (github-arm64-2c-8gb)
    • check-neutral = rust-lint (github-arm64-2c-8gb)
    • check-skipped = rust-lint (github-arm64-2c-8gb)
  • any of [🛡 GitHub branch protection]:
    • check-success = commitlint
    • check-neutral = commitlint
    • check-skipped = commitlint
  • any of [🛡 GitHub branch protection]:
    • check-success = nix-lint
    • check-neutral = nix-lint
    • check-skipped = nix-lint
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-dev (github-arm64-2c-8gb)
    • check-neutral = rust-dev (github-arm64-2c-8gb)
    • check-skipped = rust-dev (github-arm64-2c-8gb)
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-dev (ubuntu-latest)
    • check-neutral = rust-dev (ubuntu-latest)
    • check-skipped = rust-dev (ubuntu-latest)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@tiagolobocastro
Copy link
Copy Markdown
Member

@mergify requeue

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Mar 10, 2026

Merge Queue Status

  • Entered queue2026-03-10 09:31 UTC · Rule: default
  • Checks passed · in-place
  • Merged2026-03-10 09:32 UTC · at e1be4fa81f8abf08ec6287c0efb6566d4b62c951

This pull request spent 11 seconds in the queue, including 1 second running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • check-success = code-lint
  • check-success = commitlint
  • any of [🛡 GitHub branch protection]:
    • check-success = DCO
    • check-neutral = DCO
    • check-skipped = DCO
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-lint (ubuntu-latest)
    • check-neutral = rust-lint (ubuntu-latest)
    • check-skipped = rust-lint (ubuntu-latest)
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-lint (github-arm64-2c-8gb)
    • check-neutral = rust-lint (github-arm64-2c-8gb)
    • check-skipped = rust-lint (github-arm64-2c-8gb)
  • any of [🛡 GitHub branch protection]:
    • check-success = commitlint
    • check-neutral = commitlint
    • check-skipped = commitlint
  • any of [🛡 GitHub branch protection]:
    • check-success = nix-lint
    • check-neutral = nix-lint
    • check-skipped = nix-lint
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-dev (github-arm64-2c-8gb)
    • check-neutral = rust-dev (github-arm64-2c-8gb)
    • check-skipped = rust-dev (github-arm64-2c-8gb)
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-dev (ubuntu-latest)
    • check-neutral = rust-dev (ubuntu-latest)
    • check-skipped = rust-dev (ubuntu-latest)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

@mergify mergify bot added the queued label Mar 10, 2026
@mergify mergify bot merged commit 4cec792 into develop Mar 10, 2026
11 checks passed
@tiagolobocastro tiagolobocastro deleted the mergify/bp/develop/pr-98 branch April 2, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants