script: Remove unused ScriptEngine.executeScript

[dilyanpalauzov]

No description provided.

[kaikreuzer]

@dilyanpalauzov How can we be really sure that it is unused? It is a method in a public interface, so removing it feels at least API breaking, so I'm a bit hesitant...

[dilyanpalauzov]

Ideally DSL Scritps should utilize the implicit JSR223 presets — default, media and lifecycletracker — and depend on what is defined in these presets. So executing a DSL Script should only be done in the context of the presets. The herein deleted method executes DSL Scripts without considering any presets, so removing it is a step in the direction of evaluating DSL scripts in the context of JSR223 presets.

It is of course not possible to know, if unpublished add-ons use this interface method. But on the other side, if no add-on uses the method, must it really be present?

I suggest removing the method ScriptEngine.executeScript() right after openHAB 5.1.0 is released and listen to feedback, if somebody needs it. Another approach is adding a @Deprecated annotation.

[kaikreuzer]

Ok, thanks - then let's park this until 5.1 is released and then we can remove it and see if there is any unexpected feedback.