Skip to content

script: Remove unused ScriptEngine.executeScript #5105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −16
Open

script: Remove unused ScriptEngine.executeScript #5105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...t.runtime/src/org/openhab/core/model/script/runtime/internal/engine/ScriptEngineImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
import org.openhab.core.model.script.ScriptStandaloneSetup;
import org.openhab.core.model.script.engine.Script;
import org.openhab.core.model.script.engine.ScriptEngine;
import org.openhab.core.model.script.engine.ScriptExecutionException;
import org.openhab.core.model.script.engine.ScriptParsingException;
import org.openhab.core.model.script.runtime.ScriptRuntime;
import org.osgi.service.component.annotations.Activate;
Expand Down Expand Up @@ -118,11 +117,6 @@ public Script newScriptFromXExpression(XExpression expression) {
return script;
}

@Override
public Object executeScript(String scriptAsString) throws ScriptParsingException, ScriptExecutionException {
return newScriptFromString(scriptAsString).execute();
}

private XExpression parseScriptIntoXTextEObject(String scriptAsString) throws ScriptParsingException {
XtextResourceSet resourceSet = getResourceSet();
Resource resource = resourceSet.createResource(computeUnusedUri(resourceSet)); // IS-A XtextResource
Expand Down
10 changes: 0 additions & 10 deletions .../org.openhab.core.model.script/src/org/openhab/core/model/script/engine/ScriptEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,6 @@ public interface ScriptEngine {
*/
Script newScriptFromString(final String scriptAsString) throws ScriptParsingException;

/**
* Executes a script that is passed as a string
*
* @param scriptAsString
* @return the return value of the script
* @throws ScriptParsingException
* @throws ScriptExecutionException
*/
Object executeScript(final String scriptAsString) throws ScriptParsingException, ScriptExecutionException;

/**
* Wraps an Xbase XExpression in a Script instance
*
Expand Down