You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
My work is based on designs, which are linked or shown either in the Jira ticket or the description below. (See also: Styleguide)
My work includes tests or is validated by existing tests.
This PR addresses O3-5857 (prerequisite child of parent epic O3-5854). It configures @carbon/icons-react as a shared singleton provided by the app shell scope, and updates all 6 of the microfrontend apps in openmrs-esm-core to declare @carbon/icons-react inside peerDependencies.
Key Changes
App Shell (packages/shell/esm-app-shell):
Added @carbon/icons-react to dependencies.json so the shell exposes it in the shared Module Federation scope.
Added "@carbon/icons-react": "^11.58.0" to package.json / dependencies.
App Packages (packages/apps/*):
Added "@carbon/icons-react": "11.x" to peerDependencies across all 6 app packages (esm-devtools-app, esm-help-menu-app, esm-implementer-tools-app, esm-login-app, esm-offline-tools-app, esm-primary-navigation-app).
Verified @carbon/react: 1.x is already consistently declared across all app packages.
For esm-offline-tools-app: Shifted @carbon/icons-react from dependencies to peerDependencies + devDependencies to consume the shell singleton cleanly.
Verification & Testing
Executed yarn build:apps: all 30 workspace targets built cleanly.
Confirmed version specifiers (11.x) match the shell's version range (11.58.0 in lockfile).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Adds @carbon/icons-react to the app shell’s shared dependency scope and aligns the six affected microfrontend peer declarations with Carbon Icons v11. The potential shared-module compatibility failure was disproved: version 11.68.0 resolves from the app shell, satisfies its declared range and all six peer ranges, and the app shell development build completes successfully. No defects were found.
Confidence Score: 5/5
T-Rex Logs
What T-Rex did
The validation compared the pre-capture state with the post-capture state to confirm contract expectations, noting that the parent shell had no icon dependency or shared entry before, and that after capture @carbon/icons-react 11.68.0 was installed with an 11.x shared requirement, six compatible peers, 2,511 module exports, and a successful development build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR addresses O3-5857 (prerequisite child of parent epic O3-5854). It configures
@carbon/icons-reactas a shared singleton provided by the app shell scope, and updates all 6 of the microfrontend apps inopenmrs-esm-coreto declare@carbon/icons-reactinsidepeerDependencies.Key Changes
packages/shell/esm-app-shell):@carbon/icons-reacttodependencies.jsonso the shell exposes it in the shared Module Federation scope."@carbon/icons-react": "^11.58.0"topackage.json/dependencies.packages/apps/*):"@carbon/icons-react": "11.x"topeerDependenciesacross all 6 app packages (esm-devtools-app,esm-help-menu-app,esm-implementer-tools-app,esm-login-app,esm-offline-tools-app,esm-primary-navigation-app).@carbon/react: 1.xis already consistently declared across all app packages.esm-offline-tools-app: Shifted@carbon/icons-reactfromdependenciestopeerDependencies+devDependenciesto consume the shell singleton cleanly.Verification & Testing
yarn build:apps: all 30 workspace targets built cleanly.11.x) match the shell's version range (11.58.0in lockfile).Screenshots
N/A
Related Issue
https://openmrs.atlassian.net/browse/O3-5857
Other