-
Notifications
You must be signed in to change notification settings - Fork 58
[AUTO] Increment version to 3.4.0-SNAPSHOT #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
opensearch-trigger-bot
bot
commented
Oct 8, 2025
- Incremented version to 3.4.0-SNAPSHOT.
3c016b5 to
09c3f70
Compare
09c3f70 to
58ec53a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
=========================================
Coverage 77.84% 77.84%
Complexity 1223 1223
=========================================
Files 103 103
Lines 5778 5778
Branches 599 599
=========================================
Hits 4498 4498
Misses 992 992
Partials 288 288 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
58ec53a to
4c3b281
Compare
4c3b281 to
ea208c4
Compare
Signed-off-by: opensearch-ci-bot <[email protected]>
ea208c4 to
ed0c23e
Compare
|
So, we'll never merge this PR as it requires the security integ test. That's broken until #1251 gets merged. But #1251 is dependent on a fix in ML Commons and they've already bumped to 3.4.0 So easy fix is to bump version in #1251, which will make this PR redundant. .... unless @peterzhuamazon or @gaiksaya thinks there's a way to override a required test :) Edge cases FTW! |
|
#1251 should not be a blocker here as there are no resource-sharing framework related changes present in this repo just yet. this PR is blocked by ml-commons PR: opensearch-project/ml-commons#4402 (and here as well: opensearch-project/ml-commons#4333) Once either of these are merged this PR should be unblocked and then #1251 |
@DarshitChanpura @cwperks This bump is still failing on ML commons related failures following the merge of the above: What else can we do on this repo to get this version bump in? |
I can hard-merge. Let me know if you want to do that |
Let's wait a few days. The line number is 2-day old code in ML Commons so the latest change apparently hasn't made its way to the CI Image used for the security test.... |
https://hub.docker.com/r/opensearchstaging/ci-runner last updated 4 days ago... |
Those images do not change frequently. @peterzhuamazon do we need to make any infra change here? |
Hi @dbwiddis what exact change are we talking about here? |
@peterzhuamazon the (required) security test workflow is failing. It uses this container image at hub.docker.com/r/opensearchstaging/ci-runner. Here's where it's called: flow-framework/.github/workflows/test_security.yml Lines 14 to 17 in 8bc7c1e
It's used across many plugins. The current test is failing based on an ML Commons bug fixed 2 days ago but the last docker image was published 5 days ago. (The same test at the neural search repository is also failing for the same reason. CC: @martin-gaievski). Would love that image to be updated soon to unblock this version bump and pretty much any PR on this repo. Would suggest you consider more frequent updates of an image used in CI. |