Skip to content

Conversation

@opensearch-trigger-bot
Copy link
Contributor

  • Incremented version to 3.4.0-SNAPSHOT.

@opensearch-trigger-bot opensearch-trigger-bot bot added the v3.4.0 Issues targeting release v3.4.0 label Oct 8, 2025
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the create-pull-request/3.4.0-SNAPSHOT branch from 3c016b5 to 09c3f70 Compare October 10, 2025 00:10
@DarshitChanpura DarshitChanpura mentioned this pull request Oct 20, 2025
5 tasks
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the create-pull-request/3.4.0-SNAPSHOT branch from 09c3f70 to 58ec53a Compare October 24, 2025 00:09
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.84%. Comparing base (8bc7c1e) to head (ed0c23e).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1243   +/-   ##
=========================================
  Coverage     77.84%   77.84%           
  Complexity     1223     1223           
=========================================
  Files           103      103           
  Lines          5778     5778           
  Branches        599      599           
=========================================
  Hits           4498     4498           
  Misses          992      992           
  Partials        288      288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the create-pull-request/3.4.0-SNAPSHOT branch from 58ec53a to 4c3b281 Compare November 5, 2025 00:10
@dbwiddis dbwiddis mentioned this pull request Nov 5, 2025
@dbwiddis dbwiddis force-pushed the create-pull-request/3.4.0-SNAPSHOT branch from 4c3b281 to ea208c4 Compare November 5, 2025 22:13
Signed-off-by: opensearch-ci-bot <[email protected]>
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the create-pull-request/3.4.0-SNAPSHOT branch from ea208c4 to ed0c23e Compare November 6, 2025 00:11
@dbwiddis
Copy link
Member

dbwiddis commented Nov 6, 2025

So, we'll never merge this PR as it requires the security integ test. That's broken until #1251 gets merged.

But #1251 is dependent on a fix in ML Commons and they've already bumped to 3.4.0

So easy fix is to bump version in #1251, which will make this PR redundant. .... unless @peterzhuamazon or @gaiksaya thinks there's a way to override a required test :)

Edge cases FTW!

@DarshitChanpura
Copy link
Member

#1251 should not be a blocker here as there are no resource-sharing framework related changes present in this repo just yet.

this PR is blocked by ml-commons PR: opensearch-project/ml-commons#4402 (and here as well: opensearch-project/ml-commons#4333)

Once either of these are merged this PR should be unblocked and then #1251

@dbwiddis
Copy link
Member

dbwiddis commented Nov 7, 2025

#1251 should not be a blocker here as there are no resource-sharing framework related changes present in this repo just yet.

this PR is blocked by ml-commons PR: opensearch-project/ml-commons#4402 (and here as well: opensearch-project/ml-commons#4333)

Once either of these are merged this PR should be unblocked and then #1251

@DarshitChanpura @cwperks This bump is still failing on ML commons related failures following the merge of the above:

»  fatal error in thread [main], exiting
»  java.lang.InstantiationError: org.opensearch.security.spi.resources.ResourceProvider
»  	at org.opensearch.ml.resources.MLResourceSharingExtension.getResourceProviders(MLResourceSharingExtension.java:22)
»  	at org.opensearch.security.resources.ResourcePluginInfo.setResourceSharingExtensions(ResourcePluginInfo.java:76)
»  

What else can we do on this repo to get this version bump in?

@gaiksaya
Copy link
Member

gaiksaya commented Nov 7, 2025

So easy fix is to bump version in #1251, which will make this PR redundant. .... unless @peterzhuamazon or @gaiksaya thinks there's a way to override a required test :)

I can hard-merge. Let me know if you want to do that

@dbwiddis
Copy link
Member

dbwiddis commented Nov 7, 2025

So easy fix is to bump version in #1251, which will make this PR redundant. .... unless @peterzhuamazon or @gaiksaya thinks there's a way to override a required test :)

I can hard-merge. Let me know if you want to do that

Let's wait a few days. The line number is 2-day old code in ML Commons so the latest change apparently hasn't made its way to the CI Image used for the security test....

@dbwiddis
Copy link
Member

dbwiddis commented Nov 7, 2025

Let's wait a few days. The line number is 2-day old code in ML Commons so the latest change apparently hasn't made its way to the CI Image used for the security test....

https://hub.docker.com/r/opensearchstaging/ci-runner last updated 4 days ago...

@gaiksaya
Copy link
Member

gaiksaya commented Nov 7, 2025

Let's wait a few days. The line number is 2-day old code in ML Commons so the latest change apparently hasn't made its way to the CI Image used for the security test....

hub.docker.com/r/opensearchstaging/ci-runner last updated 4 days ago...

Those images do not change frequently. @peterzhuamazon do we need to make any infra change here?

@peterzhuamazon
Copy link
Member

Let's wait a few days. The line number is 2-day old code in ML Commons so the latest change apparently hasn't made its way to the CI Image used for the security test....

hub.docker.com/r/opensearchstaging/ci-runner last updated 4 days ago...

Those images do not change frequently. @peterzhuamazon do we need to make any infra change here?

Hi @dbwiddis what exact change are we talking about here?
Our images has already updated to JDK25 as default.
The only thing hasnt change on 3.4.0 is manifest switching to jdk25 but that shouldnt have any issues to compile on jdk24 anyway. Thanks.

@dbwiddis
Copy link
Member

dbwiddis commented Nov 8, 2025

Hi @dbwiddis what exact change are we talking about here? Our images has already updated to JDK25 as default.

@peterzhuamazon the (required) security test workflow is failing. It uses this container image at hub.docker.com/r/opensearchstaging/ci-runner.

Here's where it's called:

Get-CI-Image-Tag:
uses: opensearch-project/opensearch-build/.github/workflows/get-ci-image-tag.yml@main
with:
product: opensearch

It's used across many plugins.

The current test is failing based on an ML Commons bug fixed 2 days ago but the last docker image was published 5 days ago. (The same test at the neural search repository is also failing for the same reason. CC: @martin-gaievski).

Would love that image to be updated soon to unblock this version bump and pretty much any PR on this repo.

Would suggest you consider more frequent updates of an image used in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog v3.4.0 Issues targeting release v3.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants