[BUG] Latest ML Commons code fail with compilation error #4402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves opensearch-project#4401 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
akolarkunnu
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
sam-herman,
xinyual,
ylwu-amzn and
zane-neo
as code owners
akolarkunnu
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
akolarkunnu
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
akolarkunnu
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
akolarkunnu
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
|
@akolarkunnu fix for this is here: #4333 |
|
I addressed comments from @mingshl can you help approve and merge that one? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Latest ML Commons code fails with a compilation error of "ResourceProvider is abstract; cannot be instantiated". ResourceProvider class is from Security plugin and there is a recent refactoring task opensearch-project/security#5755 moved ResourceProvider as an interface. This caused the issue. So converting that instantiation code as an anonymous class implementation.
Related Issues
Resolves #4401
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.