Skip to content
This repository was archived by the owner on Aug 29, 2018. It is now read-only.

Conversation

Antoine-A
Copy link

Author: Antoine Abélard
Date: Mon Aug 04 14:29:00 2014 +0100

With the current implementation, the OpenShift Origin deployment fails when there is point (.) in the hostname.
This new implementation fix this bug.

  Author: Antoine Abélard
  Date:   Mon Aug 04 14:29:00 2014 +0100

    With the current implementation, the OpenShift Origin deployment fails when there is point (.) in the hostname.
    This new implementation fix this bug.
@ekohl
Copy link

ekohl commented Aug 4, 2014

What do you mean by a dot in the hostname? Do you mean where hostname is host.sub.example.org and domain is example.org?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be simpler to just write:

<%= scope.lookupvar('::openshift_origin::nameserver_hostname') %>.  A <%= scope.lookupvar('::openshift_origin::nameserver_ip_addr') %>

@Antoine-A
Copy link
Author

Yes, the hostname host.sub.example.org and the domain example.org is a good example. With this example, the .split('.').first function will return just "host" instead of "host.sub"
We can't just write that, because '::openshift_origin::nameserver_hostname' contains "host.sub.example.org" and we just need "host.sub"

@ekohl
Copy link

ekohl commented Aug 4, 2014

@Antoine-A bind understands fqdn. (note the dot at the end).

@Antoine-A
Copy link
Author

@ekohl Ok, so you're right, it's a simpler solution

@openshift-bot
Copy link

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@detiber
Copy link

detiber commented Nov 20, 2014

@Antoine-A can you please rebase this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants