Skip to content
This repository was archived by the owner on Aug 29, 2018. It is now read-only.

Fixed a bug which appears when hostname contains a point (.) #260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed a bug which appears when hostname contains a point (.) #260

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
875367e
Fixed a bug which appears when hostname contains a point (.)
Antoine-A Aug 4, 2014
9a0ae16
Simpler implementation proposed by ekohl
Antoine-A Aug 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion templates/named/dynamic-zone.db.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@ $TTL 1800
NS <%= scope.lookupvar('::openshift_origin::nameserver_hostname') %>.
$ORIGIN <%= scope.lookupvar('::openshift_origin::domain') %>.
<% if scope.lookupvar('::openshift_origin::nameserver_hostname').end_with?(scope.lookupvar('::openshift_origin::domain')) %>
<%= scope.lookupvar('::openshift_origin::nameserver_hostname').split('.').first %> A <%= scope.lookupvar('::openshift_origin::nameserver_ip_addr') %>
<%= scope.lookupvar('::openshift_origin::nameserver_hostname').gsub('.'+scope.lookupvar('::openshift_origin::domain'),'') %> A <%= scope.lookupvar('::openshift_origin::nameserver_ip_addr') %>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be simpler to just write:

<%= scope.lookupvar('::openshift_origin::nameserver_hostname') %>.  A <%= scope.lookupvar('::openshift_origin::nameserver_ip_addr') %>

<% end %>