[CI] [GHA] Migrate mac workflow to mac-14 arm64
#2533
Conversation
…hchi/openvino.genai into ci/gha/migrate-macos-to-arm
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the macOS CI workflow from Intel-based mac-13 runners to ARM64-based mac-14 runners to support Apple Silicon architecture.
- Updates all job runners from
macos-13tomacos-14 - Changes target architecture from
x86_64toarm64throughout the workflow - Disables certain test suites that are not supported on ARM64 without SVE support
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/mac.yml | Complete migration from mac-13 x86_64 to mac-14 arm64 runners with disabled unsupported tests |
| tests/python_tests/test_gguf_reader.py | Adds xfail marker for ARM-based platforms to skip failing test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.github/workflows/mac.yml
Outdated
| @@ -274,6 +275,7 @@ jobs: | |||
|
|
|||
| - name: Build Tokenizers Wheel | |||
| run: | | |||
| export CMAKE_BUILD_PARALLEL_LEVEL=$(( $(nproc) - 1 )) | |||
There was a problem hiding this comment.
The nproc command is not available on macOS. Use sysctl -n hw.ncpu instead to get the number of CPU cores on macOS.
| export CMAKE_BUILD_PARALLEL_LEVEL=$(( $(nproc) - 1 )) | |
| export CMAKE_BUILD_PARALLEL_LEVEL=$(( $(sysctl -n hw.ncpu) - 1 )) |
Copilot uses AI. Check for mistakes.
.github/workflows/mac.yml
Outdated
| @@ -282,13 +284,16 @@ jobs: | |||
|
|
|||
| - name: Build GenAI Wheel | |||
| run: | | |||
| export CMAKE_BUILD_PARALLEL_LEVEL=$(( $(nproc) - 1 )) | |||
There was a problem hiding this comment.
The nproc command is not available on macOS. Use sysctl -n hw.ncpu instead to get the number of CPU cores on macOS.
| export CMAKE_BUILD_PARALLEL_LEVEL=$(( $(nproc) - 1 )) | |
| export CMAKE_BUILD_PARALLEL_LEVEL=$(( $(sysctl -n hw.ncpu) - 1 )) |
Copilot uses AI. Check for mistakes.
.github/workflows/mac.yml
Outdated
| python -m pip wheel -v --no-deps --wheel-dir ${{ env.WHEELS_DIR }} \ | ||
| ${{ needs.openvino_download.outputs.ov_wheel_source }} \ | ||
| ${{ env.SRC_DIR }} | ||
| working-directory: ${{ env.OV_INSTALL_DIR }} | ||
|
|
||
| - name: Build WWB Wheel | ||
| run: python -m pip wheel -v --no-deps --wheel-dir ${{ env.WHEELS_DIR }} ${{ env.SRC_DIR }}/tools/who_what_benchmark | ||
| run: | | ||
| export CMAKE_BUILD_PARALLEL_LEVEL=$(( $(nproc) - 1 )) |
There was a problem hiding this comment.
The nproc command is not available on macOS. Use sysctl -n hw.ncpu instead to get the number of CPU cores on macOS.
| export CMAKE_BUILD_PARALLEL_LEVEL=$(( $(nproc) - 1 )) | |
| export CMAKE_BUILD_PARALLEL_LEVEL=$(( $(sysctl -n hw.ncpu) - 1 )) |
Copilot uses AI. Check for mistakes.
| @@ -405,7 +410,7 @@ jobs: | |||
| -DENABLE_JS=ON -DCPACK_GENERATOR=NPM \ | |||
| -DENABLE_PYTHON=OFF -DENABLE_WHEEL=OFF \ | |||
| -S ${{ env.SRC_DIR }} -B ${{ env.BUILD_DIR }} | |||
| cmake --build ${{ env.BUILD_DIR }} --config ${{ matrix.build-type }} --parallel --verbose | |||
| cmake --build ${{ env.BUILD_DIR }} --config ${{ matrix.build-type }} --parallel $(nproc) --verbose | |||
There was a problem hiding this comment.
The nproc command is not available on macOS. Use sysctl -n hw.ncpu instead to get the number of CPU cores on macOS.
| cmake --build ${{ env.BUILD_DIR }} --config ${{ matrix.build-type }} --parallel $(nproc) --verbose | |
| cmake --build ${{ env.BUILD_DIR }} --config ${{ matrix.build-type }} --parallel $(sysctl -n hw.ncpu) --verbose |
Copilot uses AI. Check for mistakes.
JIRA: 171611