-
Notifications
You must be signed in to change notification settings - Fork 70
feat: Add SHA-512 and SHA-384 support to the SHA-256 VM extension #1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Avaneesh-axiom
wants to merge
12
commits into
main
Choose a base branch
from
feat/sha-512
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b16f93e
to
1d6487b
Compare
This comment has been minimized.
This comment has been minimized.
1d6487b
to
4b55bbb
Compare
This comment has been minimized.
This comment has been minimized.
4b55bbb
to
6fc3985
Compare
This comment has been minimized.
This comment has been minimized.
6fc3985
to
b062b27
Compare
f718681
to
8e11373
Compare
This comment has been minimized.
This comment has been minimized.
8e11373
to
665237e
Compare
Commit: 665237e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewer: the Github PR review UI doesn't diff some files properly across renaming despite my best efforts. For example,
crates/circuits/sha256-air/src/air.rs -> crates/circuits/sha-air/src/air.rs
isn't detected and it shows as deletion of the old file and creation of the new one. To make the review easier, consider reviewing each commit one at a time. The diffs work nicer that way.The sha air is separated into two directories:
crates/circuits/sha2-air/
has the SubAir that constrains all of the hash except the padding.extensions/sha2/circuit/
has the sha chip that constrains message padding. We added, in both directories, aconfig.rs
file that stores generic parameters of each SHA-2 variant. All the constraints and tracegen were updated to be in terms of these parameters.A new guest library was also added in
guest-libs/sha2
.A new derive macro,
ColsRef
was added incrates/circuits/primitives/derive/src/cols_ref/
that helps define columns structs that work in general for all SHA-2 variants.Updated (Jun 27): Rebased onto main (from develop) to incorporate
guest-libs
changes and to support build script.Closes INT-3211 and INT-3213