-
Notifications
You must be signed in to change notification settings - Fork 70
feat: twisted Edwards curve support with new execution #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/ed25519
Are you sure you want to change the base?
Conversation
- rename remaining structs - switch from num-bigint-dig to num-bigint
…weierstrass and edwards curves)
Co-authored-by: Jonathan Wang <[email protected]>
A bug involving opcode collisions between short Weierstrass and twisted Edwards curves was found. To fix this, CurveConfig was rewritten and separate opcodes were given to the two types of curves.
CodSpeed WallTime Performance ReportMerging #1858 will degrade performances by 10.09%Comparing
|
Benchmark | BASE |
HEAD |
Change | |
---|---|---|---|---|
⚡ | benchmark_execute[bubblesort] |
38.2 ms | 34 ms | +12.46% |
❌ | benchmark_execute[factorial_iterative_u256] |
152.1 ms | 169.1 ms | -10.09% |
⚡ | benchmark_execute[keccak256] |
37.6 ms | 33.9 ms | +10.94% |
⚡ | benchmark_leaf_verifier_execute_preflight |
2.7 s | 2.1 s | +30.12% |
Footnotes
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5ab59be
to
0f4b443
Compare
0f4b443
to
831d8a4
Compare
This comment has been minimized.
This comment has been minimized.
e6ad7f8
to
5b3127b
Compare
5b3127b
to
be1e5ec
Compare
efd381d
to
1849d45
Compare
Commit: 16a8d32 |
Similar to #1255 but incorporated changes to tracegen design.