Bump to 2024 edition #1799
Merged
Bump to 2024 edition #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftwo
approved these changes
Nov 4, 2025
mkeeter
force-pushed
the
mkeeter/rust-2024
branch
from
032405a to
d79fbea
Compare
mkeeter
force-pushed
the
mkeeter/rust-2024
branch
from
d79fbea to
1b1d1f1
Compare
mkeeter
added a commit
that referenced
this pull request
Nov 6, 2025
#1799 renamed `gen` → `generation`, because the former is a reserved word in Rust 2024. That PR special-cased the `generation` field in the volume construction request, because it's serialized to disk; however, we should also special-case CLI arguments to avoid breaking existing scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got tired of my editor's LSP complaining about
gen, and decided to update everything to Rust 2024.This was mostly mechanical renaming of
gen→generation, Clippy fixes, andrustfmt.VolumeConstructionRequesthas to have a#[serde(rename = "gen")]annotation, because it's been stored on disk.