-
Notifications
You must be signed in to change notification settings - Fork 20
Sync releases to the eln branch
#500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nikola Forró <[email protected]>
Summary of ChangesHello @nforro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the Packit configuration to extend the synchronization of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Packit configuration to also sync releases from the rawhide branch to the eln branch. The change is applied to two separate jobs, which introduces some duplication into the configuration file. I've left a suggestion to refactor this using YAML anchors to improve maintainability, which could be handled in a follow-up.
| rawhide: | ||
| fast_forward_merge_into: | ||
| - fedora-branched | ||
| - eln |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces duplication. The fast_forward_merge_into configuration for rawhide is now identical here and in the pull_from_upstream job definition (line 228). To improve maintainability and avoid potential inconsistencies in the future, consider using a YAML anchor to define this configuration once and reuse it in both places.
For example, you could define an anchor:
x-rawhide-ff-config: &rawhide-ff-config
fast_forward_merge_into:
- fedora-branched
- elnAnd then reference it in both jobs:
# ... in propose_downstream job
rawhide:
<<: *rawhide-ff-config
# ...
# ... in pull_from_upstream job
rawhide:
<<: *rawhide-ff-configThis would make the configuration easier to manage if more branches need to be added in the future. Since this would require changes outside of the current diff, it could be addressed in a follow-up.
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 13s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 01s |
|
Why does python-specfile need an eln branch? See https://docs.fedoraproject.org/en-US/eln/eln-branch/. |
It doesn't. But we want to dogfood Packit as Fedora CI for ELN as well, to catch potential issues early. |
Related to packit/packit-service#2822.