Skip to content

Sync releases to the eln branch #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
centosinfra-prod-github-app merged 1 commit into from
Jan 5, 2026
Merged

Sync releases to the eln branch #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .packit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ jobs:
rawhide:
fast_forward_merge_into:
- fedora-branched
- eln
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change introduces duplication. The fast_forward_merge_into configuration for rawhide is now identical here and in the pull_from_upstream job definition (line 228). To improve maintainability and avoid potential inconsistencies in the future, consider using a YAML anchor to define this configuration once and reuse it in both places.

For example, you could define an anchor:

x-rawhide-ff-config: &rawhide-ff-config
  fast_forward_merge_into:
    - fedora-branched
    - eln

And then reference it in both jobs:

# ... in propose_downstream job
rawhide:
  <<: *rawhide-ff-config
# ...
# ... in pull_from_upstream job
rawhide:
  <<: *rawhide-ff-config

This would make the configuration easier to manage if more branches need to be added in the future. Since this would require changes outside of the current diff, it could be addressed in a follow-up.

epel-9: {}
- <<: *propose_downstream
packages: [specfile-epel8]
Expand All @@ -224,6 +225,7 @@ jobs:
rawhide:
fast_forward_merge_into:
- fedora-branched
- eln
epel-9: {}
- <<: *pull_from_upstream
packages: [specfile-epel8]
Expand Down
Loading