Skip to content

Fix SimpleXMLElement::offsetSet #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from
Open

Fix SimpleXMLElement::offsetSet #4196

wants to merge 1 commit into from

Conversation

VincentLanglet
Copy link
Contributor

VincentLanglet
VincentLanglet commented Aug 1, 2025
View reviewed changes
stubs/iterable.stub
@@ -99,6 +99,13 @@ class SimpleXMLElement implements Traversable, ArrayAccess, Iterator, RecursiveI
*/
public function saveXML(?string $filename = null) { }

/**
* @param int|string $key
* @param self|string|int|float|bool $value
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept consistency with

phpstan-src/src/Reflection/Php/SimpleXMLElementProperty.php

Lines 79 to 88 in 9dbff97

public function getWritableType(): Type
{
return TypeCombinator::union(
$this->type,
new IntegerType(),
new FloatType(),
new StringType(),
new BooleanType(),
);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SimpleXMLElement Should Accept String
1 participant
@VincentLanglet