feat: add optional 3D visualisation to standard web dashboard#839
Open
8bitkick wants to merge 6 commits intopollen-robotics:mainfrom
Open
feat: add optional 3D visualisation to standard web dashboard#8398bitkick wants to merge 6 commits intopollen-robotics:mainfrom
8bitkick wants to merge 6 commits intopollen-robotics:mainfrom
Conversation
…d pose application
…nd remove status updates
8bitkick
changed the title
Member
|
Ping @AnneCharlotte-pollen , @tfrere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds live 3D Viz into the standard Reachy web dashboard (inspired by Jeff Geerling review observation )
TRADE OFFS
I didn't want to add a bunch of npm dependencies to the robot daemon build.
The current solution imports from CDN only when feature is accessed in web client.
Dependency on external CDN - JS Delivr for Three.js and URDF Loader packages
Dependent on Hugging Face CDN for the 3D assets
The fact it's lazy loading a UI feature behind a small button, means calling external CDN is perhaps acceptable (but not ideal).
POTENTIAL IMPROVEMENTS
If Pollen think the feature is worthwhile, we can remove external deps
Ideally the visual optimized GLB 3D assets would be available via reachy-mini-daemon API route in the same way STLs are (would require a separate PR)
Hosting this feature as a js module plugin on HF would be cleaner, removing third party CDN dependencies without adding them to the robot daemon build
web-3d-viz-update.mp4
Cc @pierre-rouanet