refactor(native): Use getVectorSerdeOptions() from OperatorUtils.h

[tanjialiang]

Summary: Use the centralized method for convenient getting vector serde options.

Differential Revision: D84941606

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This refactor removes the duplicated local implementation of getVectorSerdeOptions in BroadcastWrite.cpp and adopts the centralized helper from OperatorUtils, updating the include and call site accordingly.

Class diagram for BroadcastWriteOperator after refactor

classDiagram
    class BroadcastWriteOperator {
        +BroadcastWriteOperator(const std::shared_ptr<BroadcastFile>& fileBroadcast, OperatorCtx* ctx)
        +needsInput() const bool
        +addInput(RowVectorPtr input)
        +isFinished() const bool
        +getOutput() RowVectorPtr
        -fileBroadcastWriter_
    }
    class Operator
    BroadcastWriteOperator --|> Operator
    class BroadcastFile {
        +createWriter(size_t bufferSize, memory::MemoryPool* pool, std::unique_ptr<VectorSerde::Options> options)
    }
    BroadcastWriteOperator o-- BroadcastFile
    class VectorSerde {
        class Options
        class Kind
    }
    class OperatorUtils {
        +getVectorSerdeOptions(CompressionKind kind, VectorSerde::Kind serdeKind) : std::unique_ptr<VectorSerde::Options>
    }
    BroadcastWriteOperator ..> OperatorUtils : uses getVectorSerdeOptions
    OperatorUtils ..> VectorSerde : returns Options

Loading

Class diagram for removal of local getVectorSerdeOptions implementation

classDiagram
    class BroadcastWriteOperator {
        -getVectorSerdeOptions(const core::QueryConfig& queryConfig, VectorSerde::Kind kind) : std::unique_ptr<VectorSerde::Options> [REMOVED]
    }

Loading

File-Level Changes

Change	Details	Files
Removed local getVectorSerdeOptions implementation in favor of the centralized version	Deleted the duplicate function definition and associated TODO comment Added include of OperatorUtils.h	presto_cpp/main/operators/BroadcastWrite.cpp
Updated getVectorSerdeOptions call signature to match the new helper	Changed call to pass compressionKind instead of full QueryConfig Adjusted formatting around the call site	presto_cpp/main/operators/BroadcastWrite.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}