Skip to content

refactor(native): Use getVectorSerdeOptions() from OperatorUtils.h #26358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(native): Use getVectorSerdeOptions() from OperatorUtils.h #26358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions presto-native-execution/presto_cpp/main/operators/BroadcastWrite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*/
#include "presto_cpp/main/operators/BroadcastWrite.h"
#include "presto_cpp/main/operators/BroadcastFactory.h"
#include "velox/exec/OperatorUtils.h"

using namespace facebook::velox::exec;
using namespace facebook::velox;
Expand All @@ -23,22 +24,7 @@ velox::core::PlanNodeId deserializePlanNodeId(const folly::dynamic& obj) {
return obj["id"].asString();
}

// TODO: This is a copy from Exchange.cpp. We should refactor
// such that this method is globally accessible from a single location. This is
// to prevent diverges of serde options during write and read.
std::unique_ptr<VectorSerde::Options> getVectorSerdeOptions(
const core::QueryConfig& queryConfig,
VectorSerde::Kind kind) {
std::unique_ptr<VectorSerde::Options> options =
kind == VectorSerde::Kind::kPresto
? std::make_unique<serializer::presto::PrestoVectorSerde::PrestoOptions>()
: std::make_unique<VectorSerde::Options>();
options->compressionKind =
common::stringToCompressionKind(queryConfig.shuffleCompressionKind());
return options;
}

// BroadcastWriteOperator writes input RowVectors to specified file.
/// BroadcastWriteOperator writes input RowVectors to specified file.
class BroadcastWriteOperator : public Operator {
public:
BroadcastWriteOperator(
Expand All @@ -60,7 +46,10 @@ class BroadcastWriteOperator : public Operator {
fileBroadcastWriter_ = fileBroadcast.createWriter(
8 << 20,
operatorCtx_->pool(),
getVectorSerdeOptions(ctx->queryConfig(), VectorSerde::Kind::kPresto));
getVectorSerdeOptions(
common::stringToCompressionKind(
ctx->queryConfig().shuffleCompressionKind()),
VectorSerde::Kind::kPresto));
}

bool needsInput() const override {
Expand Down
Loading