Adding ModeTag list validation #41541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a validation check to ensure there are no duplicate ModeTag values within the modeTags list for each supported mode in the ModeBase cluster. The implementation correctly uses a list-to-set comparison to detect duplicates, which is an efficient and idiomatic Python approach. The corresponding docstring has also been updated to reflect this new validation. The changes are clear, correct, and improve the robustness of the test. No issues were found.
|
PR #41541: Size comparison from c1f377d to 5a3cf66 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41541 +/- ##
=======================================
Coverage 51.05% 51.05%
=======================================
Files 1385 1385
Lines 100882 100882
Branches 13055 13055
=======================================
+ Hits 51508 51509 +1
+ Misses 49374 49373 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #41541: Size comparison from 4f17295 to 33270a1 Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11767
Test plan update: https://github.com/CHIP-Specifications/chip-test-plans/pull/5632
Adds a duplication
modeTagvalidation inModeOptionStruct.Testing
Terminal 1:
Terminal 2: