Skip to content

Adding ModeTag list validation #41541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding ModeTag list validation #41541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a3cf66
Adding ModeTag list validation
r-recchia Oct 20, 2025
33270a1
Merge branch 'master' into modetag-list-condition
r-recchia Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/python_testing/modebase_cluster_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def check_tags_in_lists(self, supported_modes, required_tags=None):

This function evaluates the ModeTags of each ModeOptionStruct:
- Should have at least one tag.
- There are no duplicates in ModeTag list.
- Should be maximum 16bits in size.
- Should be a Mfg tag or one of the supported ones (either common or specific).
- Should have at least one common or specific tag.
Expand All @@ -110,7 +111,12 @@ def check_tags_in_lists(self, supported_modes, required_tags=None):
if len(mode_option_struct.modeTags) == 0:
asserts.fail("The ModeTags field should have at least one entry.")

# Check each ModelTag
# There are no duplicates
tag_values = [tag.value for tag in mode_option_struct.modeTags]
if len(tag_values) != len(set(tag_values)):
asserts.fail(f"ModeTags contain duplicates in mode {mode_option_struct.mode}: {tag_values}.")

# Check each ModeTag
at_least_one_common_or_derived = False
for tag in mode_option_struct.modeTags:
# Value should not larger than 16bits
Expand Down
Loading