Skip to content

removal of hashtables and everything based on hashbase from tools.h#262

Open
Duskhorn wants to merge 59 commits into
project-imprimis:mainfrom
Duskhorn:map2
Open

removal of hashtables and everything based on hashbase from tools.h#262
Duskhorn wants to merge 59 commits into
project-imprimis:mainfrom
Duskhorn:map2

Conversation

@Duskhorn

@Duskhorn Duskhorn commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

Attempt to close Issue #257
Remade from #258

Duskhorn and others added 30 commits September 7, 2022 10:03
Comment thread src/engine/interface/console.cpp Outdated
Comment thread src/engine/interface/console.cpp Outdated
Comment thread src/engine/interface/console.cpp Outdated
Comment thread src/engine/interface/console.cpp Outdated
Comment thread src/engine/interface/console.cpp Outdated
Comment thread src/engine/render/shader.cpp Outdated
Comment thread src/engine/render/shader.cpp Outdated
Comment thread src/engine/render/shader.cpp Outdated
Comment thread src/engine/render/octarender.cpp Outdated
Comment thread src/engine/model/animmodel.cpp Outdated
@Duskhorn

Duskhorn commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

Right now I just have 3 hashtables left.

  1. hashtable<vec, int> share; in animmodel.h:144
  2. hashtable<ivec, int> verthash(1<<11); in obj.cpp:75
  3. static hashtable<cfkey, cfpolys> cpolys; in octacube.cpp:718

For the first two, we either go the std::hash route or we reimplement them.
For the thrid one, I'm not sure

@Duskhorn Duskhorn closed this Mar 3, 2023
@Duskhorn Duskhorn reopened this Mar 3, 2023
@Duskhorn

Copy link
Copy Markdown
Contributor Author

sooo what do we do about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants