Skip to content

Conversation

@p-shg
Copy link
Contributor

@p-shg p-shg commented Sep 19, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

Working on Muscle driven dynamics for models with holonomic constraints
@pariterre the arm26_pendulum_swingup_Muscle_algebraic.py file reproduces the plotting error I told you about


This change is Reviewable

p-shg added 2 commits September 18, 2025 21:53
Specifically using more objects, or more than one constraint, on different objects or on the same object pair. This should help newer users of holonomic constraints understand this better
Copy link
Collaborator

@Ipuch Ipuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ipuch reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @p-shg)


bioptim/examples/holonomic_constraints/arm26_pendulum_swingup_Muscle_algebraic.py line 1 at r1 (raw file):

"""

"muscle_algebraic.py"


bioptim/examples/holonomic_constraints/four_bar.py line 1 at r1 (raw file):

"""

add the test somewhere.


bioptim/examples/holonomic_constraints/custom_dynamics.py line 166 at r1 (raw file):

class HolonomicMusclesDynamics(HolonomicTorqueDynamics):

put everything in custom_dynamics_muscle.py, copy paste or import from the other file.


bioptim/examples/holonomic_constraints/arm26_pendulum_swingup.py line 1 at r1 (raw file):

"""

Not necessary


bioptim/examples/holonomic_constraints/arm26_pendulum_swingup_Muscle.py line 1 at r1 (raw file):

"""

name of the file "_muscle.py"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants