Skip to content

Add wait-for-workflows #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
int128 merged 4 commits into from
Jan 27, 2026
Merged

Add wait-for-workflows #1021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
582499b
Add wait-for-workflows
int128 Jan 27, 2026
28bd3f4
Fix paths
int128 Jan 27, 2026
fd7d32c
Merge branch 'main' into int128/Add-wait-for-workflows
int128 Jan 27, 2026
1cac57c
Fix paths
int128 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,21 @@ name: build

on:
pull_request:
paths:
- .github/workflows/build.yaml
- .github/workflows/reusable--*.yaml
- Dockerfile
- entrypoint.sh
- e2e-test/**
- hack/**
Comment on lines 8 to 11
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path filter includes e2e-tests/**, but this repository directory is e2e-test/ (singular). As written, PRs that change e2e-test/** won’t trigger this workflow.

Copilot uses AI. Check for mistakes.
Comment on lines 4 to +11
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description only mentions adding a wait-for-workflows status check, but this also adds paths: filters to the main build workflow (changing when CI runs for PRs and pushes). If this is intentional, please reflect it in the PR description; if not, consider reverting these trigger changes to avoid unexpected CI gaps.

Copilot uses AI. Check for mistakes.
push:
paths:
- .github/workflows/build.yaml
- .github/workflows/reusable--*.yaml
- Dockerfile
- entrypoint.sh
- e2e-test/**
- hack/**
Comment on lines 16 to 19
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue on the push trigger: e2e-tests/** does not exist (repo uses e2e-test/). This will prevent builds on pushes that modify e2e tests.

Copilot uses AI. Check for mistakes.
Comment on lines 12 to +19
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding paths: filters under on: push: changes tag-triggered behavior: the workflow will only run for tag pushes if the tagged commit modifies one of these paths. If this workflow is expected to run for every tag (it currently has tags: ['*']), this can silently stop builds/releases for tags. Consider removing the paths filter for tag pushes (e.g., keep it only for pull_request, or split into separate workflows/events).

Copilot uses AI. Check for mistakes.
branches:
- main
tags:
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/wait-for-workflows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: wait-for-workflows

on:
pull_request:

jobs:
wait-for-workflows:
runs-on: ubuntu-slim
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs-on: ubuntu-slim is not a valid GitHub-hosted runner label (common labels are ubuntu-latest, ubuntu-24.04, ubuntu-22.04). This job will fail to start unless you have a self-hosted runner with the ubuntu-slim label; switch to a supported runner label or your self-hosted label.

Suggested change
runs-on: ubuntu-slim
runs-on: ubuntu-latest

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow/job doesn’t declare permissions:. The rest of the repo’s workflows explicitly set minimal permissions (e.g. .github/workflows/build.yaml:28-31), and wait-for-workflows-action typically needs API write access (e.g. to create/update check runs). Add explicit permissions at the workflow or job level per the action’s requirements so it won’t fail under restricted default token permissions.

Suggested change
runs-on: ubuntu-slim
runs-on: ubuntu-slim
permissions:
checks: write
contents: read

Copilot uses AI. Check for mistakes.
timeout-minutes: 15
steps:
- uses: int128/wait-for-workflows-action@6f56a701a797895c1196d4e36554124637c639dd # v1.55.0
Comment on lines +6 to +11
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new workflow doesn’t declare any explicit permissions. In this repo, other workflows/jobs set minimal permissions explicitly (e.g., .github/workflows/build.yaml:28-31, .github/workflows/reusable--build.yaml:22-24). Add an explicit permissions block here (at least contents: read, and whatever else the wait action needs) so behavior doesn’t depend on repository default token permissions.

Copilot uses AI. Check for mistakes.